search

justintadlock / butterbean

A neat little post meta framework.
GNU General Public License v2.0
204 stars 31 forks source link

WordPress PHP Coding Standards #25

Closed slaFFik closed 7 years ago

slaFFik commented 7 years ago

Could you please follow WordPress PHP Coding Standards?

I'm partucularly asking about braces: https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#brace-style

Example:

// If we have don't have a new value but do have an old one, delete it.
if ( ! $new_value && $old_value )
    delete_post_meta( $this->manager->post_id, $this->name );

// If the new value doesn't match the old value, set it.
else if ( $new_value !== $old_value )
    update_post_meta( $this->manager->post_id, $this->name, $new_value );

Adding {} will greatly improve readability.

justintadlock commented 7 years ago

No.

See: https://github.com/justintadlock/butterbean/blob/master/contributing.md#coding-standards