search

justintadlock / cleaner-gallery

Official repository for the Cleaner Gallery WordPress plugin.
GNU General Public License v2.0
23 stars 11 forks source link

Stop invalid key notice #2

Closed ddelrio1986 closed 7 years ago

ddelrio1986 commented 8 years ago

Just wondering if you ever had time to look over this?

justintadlock commented 8 years ago

I probably haven't if there's not an issue posted.

ddelrio1986 commented 8 years ago

So you want me to create an issue for it first?

ddelrio1986 commented 8 years ago

I've already created a patch for the issue I ran into so I didn't see a need to create an issue for it. Instead I just wanted to share my patch with the main repository to help make it better.

justintadlock commented 8 years ago

Yeah, there'd need to be an issue before I'd consider any PRs for something.

ddelrio1986 commented 8 years ago

Okay I'll create an issue then and link this PR to the issue.

ddelrio1986 commented 8 years ago

I didn't see any CONTRIBUTING.md explaining the way you'd like people to contribute. I could create a PR for adding one to the repository so in the future people know that you want an issue for the PR instead of just a PR. Want me to do that?

ddelrio1986 commented 8 years ago

Okay I've added an issue for it.

ddelrio1986 commented 8 years ago

Let me know if you'd like me to create a PR that'll add a CONTRIBUTING.md that explains to others that you'd like an issue tied to any PR's so that others know in the future that you won't look at the PR unless it has an issue.

ddelrio1986 commented 8 years ago

So did you have anytime to check this out?

ddelrio1986 commented 8 years ago

Still maintaining this?

lkraav commented 8 years ago

I'm not familiar with the issue specifics (yet), but the PR should not contain the random .gitignore change.

lkraav commented 8 years ago

You also have clear whitespace error in the main improvement - tabs vs spaces.

lkraav commented 8 years ago

How does one arrive at the settings array getting desynced in the first place? Hiding this problem with a silencer might actually mask a deeper problem.