search

justintadlock / hybrid-base

A base theme for building with the Hybrid Core framework.
GNU General Public License v2.0
154 stars 74 forks source link

loop-nav: should .previous be .prev? #5

Open lkraav opened 10 years ago

lkraav commented 10 years ago

This is to eliminate the difference with paginate_links()

http://core.trac.wordpress.org/browser/tags/3.6.1/wp-includes/general-template.php#L1994

AFAiCS theme's navigation class should follow core naming, so we don't have to chase this in styling. Am I missing anything significant with this reasoning?

justintadlock commented 10 years ago

Core naming doesn't really matter in this instance. .previous is more consistent with my other themes. Plus, core isn't even consistent with this naming and doesn't always use the class: http://core.trac.wordpress.org/browser/tags/3.6.1/wp-includes/link-template.php#L1612

I've got some Hybrid Core filters I plan on adding for cleaning some of this stuff up though.