justintadlock / hybrid-base

A base theme for building with the Hybrid Core framework.
GNU General Public License v2.0
154 stars 73 forks source link

Add shortcut icon support? #6

Closed lkraav closed 11 years ago

lkraav commented 11 years ago

"ack shortcut" doesn't reveal anything in hybrid-core either, so thought I'd find out what your stance is on adding some streamlined add_theme_support type thing for a favicon?

 add_filter( "wp_head", function() {
     printf( '<link rel="shortcut icon" href="%s" type="image/x-icon" />', get_stylesheet_directory_uri() . "/img/favicon.ico" );
 } );

works but why keep repeating that in child themes. Thoughts?

justintadlock commented 11 years ago

This is better managed with a plugin. I think there was something like that at one time in Hybrid Core (maybe when HC was just a part of the Hybrid theme?). I don't know. It's definitely gone now. It's not something that's going in though. Themes shouldn't be messing with this, so it's not something I'd want to promote in the base theme for developing with Hybrid Core.

sheabunge commented 11 years ago

Additionally, you are using the old syntax for favicons. See http://www.jonathantneal.com/blog/understand-the-favicon/ for more info.

lkraav commented 11 years ago

Thanks