justinwon777 / HumanCompanions

Human Companions Mod
GNU General Public License v3.0
3 stars 15 forks source link

Request: use "hire them" instead of "tame it" wording, since they are human #40

Open son0fether opened 1 year ago

son0fether commented 1 year ago

I'd like to request a string change. I know that internally, the human companions are tamed mobs. However, the "tame" terminology is used at one point in the GUI for the mod. It feels pretty weird to see "... It can be tamed again." in the tooltip for the "Release" button. Could that be "... They can be hired again." instead, please? That's in CompanionScreen.java.

Taming/hiring the companions can also trigger the Best Friends Forever advancement, which says "tame an animal", but I don't think that's super bad. It's just one message, and I think most people would recognize that was just because it was using the tamed animal mechanics under the hood.

I'm playing 1.19.2. This mod is working well for me, and it seems fairly solidly programmed. Thanks for making it.