search

justinwoo / purescript-simple-json

A simple Purescript JSON library that uses types automatically
http://purescript-simple-json.readthedocs.io
MIT License
133 stars 45 forks source link

writeJson #8

Closed justinwoo closed 7 years ago

justinwoo commented 7 years ago

This library really needs a write Json implementation.

@paf31 is it okay with you if I write an implementation into this library? I feel like it might not be kosher for me to just put it in here since I saw your implementation first.

justinwoo commented 7 years ago

Ah, seems like we will need to do a lot of work anyway so my concerns about being a copycat implementation are probably unfounded.

paf31 commented 7 years ago

I'm not sure which code of mine you're referring to 😄

justinwoo commented 7 years ago

You had a stringify implementation a while back that checked the types of the fields, but in our case we need to actually write to Foreign since we support non-primitive types

justinwoo commented 7 years ago

Implemented!