justinwoo / spago2nix

Generate a derivation of (old) Spago dependencies, and use them to install them into the directory structure used by Spago.
MIT License
42 stars 22 forks source link

Warning causes readPackage to fail JSON parsing #13

Open Shou opened 4 years ago

Shou commented 4 years ago

When spago list-packages -f transitive -j emits a warning like WARNING: wasn't able to check if your package set file is frozen to stdout it becomes a parse error. Is it worth instead omitting lines that failed parsing in spagoListPackages, maybe with a warning? E.g. Failed to JSON parse: WARNING: wasn't able to ....

See also https://github.com/spacchetti/spago/issues/256

justinwoo commented 4 years ago

you might try making some workarounds, yeah. i would like this to eventually just be fixed in spago, but i'll merge a fix for this

justinwoo commented 4 years ago

oh, sorry, my comment was ambiguous i think. could you make a small PR to filter this? then i can merge it

justinwoo commented 4 years ago

Might be nice if someone looked into this sometime.