search

justinwoo / spago2nix

Generate a derivation of (old) Spago dependencies, and use them to install them into the directory structure used by Spago.
MIT License
42 stars 23 forks source link

Fix hard-coded node path #17

Closed shmish111 closed 4 years ago

shmish111 commented 4 years ago

This was breaking spaho2nix when used in a derivation.

justinwoo commented 4 years ago

sounds good, but could you make this use node 10 or 12? the default in nixpkgs is often whatever the most dead or officially deprecated version is, not the correct stable version

shmish111 commented 4 years ago

I could set it to pkgs.nodejs-10_x as this is what I use however isn't this a bit restrictive if someone wants to use pkgs.nodejs-12_x or something?

justinwoo commented 4 years ago

we can make this full enterprise by adding a nodejs ? pkgs.nodejs-10_x to the top as an optional formal argument

justinwoo commented 4 years ago

apparently we already do this with dhall-json, which i didn't know

justinwoo commented 4 years ago

thanks