search

justinwoo / spago2nix

Generate a derivation of (old) Spago dependencies, and use them to install them into the directory structure used by Spago.
MIT License
42 stars 22 forks source link

Improvements #34

Closed jamesdbrock closed 3 years ago

jamesdbrock commented 3 years ago

Hi Justin, thanks for this library. In order to make it work for me, I had to make the following changes, which I think are improvements? It seems like there are multiple ways to use spago2nix, and I don't understand them all. I also documented what I did to get it working for me.

There are four commits here.

  1. Add a mkbin.nix script for Nix isolation of npm run mkbin.

  2. Fixed a bug introduced in #27 , which made spago2nix download all of package-sets instead of just the dependencies.

  3. I'm not sure why these quote escapes were here? Are these required for some other way of using spago2nix? The only way I can make this work is by removing these quote escapes. Resolves #30 , probably.

  4. Workflow README

justinwoo commented 3 years ago

Nice, planning to look at this more in detail, but looks good already.

justinwoo commented 3 years ago

I think that bug with the quote escaping probably broke as a result of the file path globs being double quoted, i.e. ""file/path"". But I haven't looked into this further to find out.