search

justinwoo / spago2nix

Generate a derivation of (old) Spago dependencies, and use them to install them into the directory structure used by Spago.
MIT License
42 stars 23 forks source link

Use niv to pin dependencies. #35

Closed dhess closed 3 years ago

dhess commented 3 years ago

This unifies all the various fetchFromGitHub instances scattered across the multiple .nix files into a single, canonical source for each dependency. It also pins the nixpkgs used to build the package, to reduce impurities.

justinwoo commented 3 years ago

I do not use niv and do not plan to ever use niv, so I don't see any merging of this PR in the future happening. Do you have some specific wishes otherwise?

On Sun, Oct 11, 2020, 17:05 Drew Hess notifications@github.com wrote:

This unifies all the various fetchFromGitHub instances scattered across the multiple .nix files into a single, canonical source for each dependency. It also pins the nixpkgs used to build the package, to reduce impurities.

You can view, comment on, or merge this pull request online at:

https://github.com/justinwoo/spago2nix/pull/35 Commit Summary

  • Use niv to pin dependencies.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/justinwoo/spago2nix/pull/35, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASJF7TSQKYWLCWVBZ4GSPLSKG3TNANCNFSM4SLZKHEA .

dhess commented 3 years ago

Yes. In the current tree, there are at least 3 different places where fetchFromGitHub is used to fetch easy-purescript-nix. If you want to update the version that's being fetched, you have to a) update the rev and sha256 at each location, and b) be disciplined to keep them in sync.

It would also be nice to pin the nixpkgs used, rather than doing an impure import <nixpkgs> {} at the top of each Nix file, though that's mostly down to preference and not particularly a maintenance issue.

justinwoo commented 3 years ago

Yes, I agree easy purescript nix should be imported once in one file and the same pinned nixpkgs should be used as default in all files

On Sun, Oct 11, 2020, 17:19 Drew Hess notifications@github.com wrote:

Yes. In the current tree, there are at least 3 different places where fetchFromGitHub is used to fetch easy-purescript-nix. If you want to update the version that's being fetched, you have to a) update the rev and sha256 at each location, and b) be disciplined to keep them in sync.

It would also be nice to pin the nixpkgs used, rather than doing an impure import {} at the top of each Nix file, though that's mostly down to preference and not particularly a maintenance issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/justinwoo/spago2nix/pull/35#issuecomment-706711620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASJF7QCJSANP7XRSSKPW5TSKG5IHANCNFSM4SLZKHEA .

dhess commented 3 years ago

So it sounds like you agree with the change in principle, but object to the implementation, is that right?

justinwoo commented 3 years ago

Sorry, do you mean to come off as rude in this comment? I believe this is basically what we have been discussing here.

On Sun, Oct 11, 2020, 17:23 Drew Hess notifications@github.com wrote:

So it sounds like you agree with the change in principle, but object to the implementation, is that right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/justinwoo/spago2nix/pull/35#issuecomment-706712187, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASJF7SZDXU4NUHNZPIYOB3SKG5W3ANCNFSM4SLZKHEA .

dhess commented 3 years ago

I'm just trying to work with you here, Justin. I find it difficult to figure out what you want from contributors.