search

justjake / Gauss

Stable Diffusion macOS native app
GNU General Public License v3.0
1.37k stars 32 forks source link

Dependency on forked model #2

Closed StefPac closed 1 year ago

StefPac commented 1 year ago

Thank you so much for building this and sharing it with the world! I wanted to ask whether it is absolutely necessary to depend on your fork of the model, which adds maintenance burden to you or gets obsolete perhaps quickly. Cheers!

justjake commented 1 year ago

The fork has very minor changes that may already be fixed upstream at this point:

  1. Using a correct type for the seed to avoid overflow panic.
  2. Making image batch size a per-batch option instead of a per-pipeline option.

It should be trivial to use upstream if/when fixes for those issues are merged there.

justjake commented 1 year ago

Yep, it looks like upstream has fixed all the issues, so I'll switch over to that.