search

justjanne / powerline-go

A beautiful and useful low-latency prompt for your shell, written in go
GNU General Public License v3.0
2.73k stars 268 forks source link

make foreground color bold #349

Closed buckley310 closed 2 years ago

buckley310 commented 2 years ago

As asked in https://github.com/justjanne/powerline-go/issues/84

Does anyone dislike the idea of just making the font always bold? It looks better in my opinion, and it seems to be the norm for most powerline setups. (https://www.google.com/search?q=powerline+bash&tbm=isch)

I've been carrying this patch for a while on my PCs. image First prompt is current behavior. Second prompt is with the bold patch.

scop commented 2 years ago

Does anyone dislike the idea of just making the font always bold?

I do :) Unfortunately I only found out about this change now. No single choice fits all tastes and this stuff is highly subjective, but in my opinion, making it bold makes the prompt somewhat harder to read and stand out too much -- the really important stuff on the console is not what what's in the prompt but between them.

I've been carrying this patch for a while on my PCs.

It seems it's my turn to start carrying the revert patch around until some other solution is found :P

buckley310 commented 2 years ago

I'll see if I can work out how to integrate boldness into the themes stuff. I've thrown a few minor patches over the wall, maybe it's time for a larger one 😅. The only perfect solution is to make boldness configurable per-segment, I agree one style will never be best for everyone.

justjanne commented 2 years ago

I integrated it into the themes and changed the default back to not be bold :)