search

justjanne / powerline-go

A beautiful and useful low-latency prompt for your shell, written in go
GNU General Public License v3.0
2.74k stars 269 forks source link

Adding venv check for VIRTUAL_ENV_PROMPT and assuring an empty 'prompt… #391

Closed philion closed 4 months ago

philion commented 10 months ago

…' field doens't erase a valid venv.

Specific issues:

  1. No check for VIRTUAL_ENV_PROMPT.
  2. Logic error looking for "prompt" after successfully loading "pyvenv.cfg", where that config file doesn't have that key defined. (Side note: Key() will create a new key with an empty value, according to the source.)

I have patched and tested "on my own machine".

scop commented 4 months ago

I believe these were more/less covered by the merged PR's #387 and #389.

philion commented 4 months ago

Concurring with @scop . Happy with the recent merges.