search

justmars / statute-patterns

Construction of regex patterns for Philippine statutory law.
https://lawsql.com
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Bad logic in units creation #8

Closed justmars closed 1 year ago

justmars commented 1 year ago

https://github.com/justmars/statute-patterns/blob/d3d997cb1ab1ed6821de450467380224f0bbe906/statute_patterns/components/details.py#L31

The appropriation markers in the title should only lead to a canned units result, i.e.

https://github.com/justmars/statute-patterns/blob/d3d997cb1ab1ed6821de450467380224f0bbe906/statute_patterns/components/utils.py#L17

If no existing units path exists. At present, it applies the canned unit results even with a pre-existing path.

justmars commented 1 year ago

See result of RA 11716 added to the /tests/data/statutes

StatuteDetails(
    rule=Rule(cat='ra', id='11716'),
    title='An Act Increasing The Bed Capacity Of The Northern Mindanao Medical Center In Cagayan De Oro City, Amending For The Purpose Republic Act No. 7938, As Amended By Republic Act No. 10677, And Appropriating Funds Therefor',
    ...
    units=[{'item': 'Container 1', 'content': 'Appropriation laws are excluded.'}]