.eslintrc has invalid duplicate setting from npm

jprianos-accusoft commented 8 years ago

The .eslintrc file in the npm package is invalid, causing linting checks to fail.

Steps to reproduce:

$ eslint index.js YAMLException: Cannot read config file: /path/to/node_modules/extend/.eslintrc Error: duplicated mapping key at line 45, column 30: "beforeLineComment": false,

Related part of .eslintrc:

  "lines-around-comment": [2, {
        "beforeBlockComment": false,
        "afterBlockComment": false,
        "beforeLineComment": false,
        "beforeLineComment": false,
        "allowBlockStart": true,
        "allowBlockEnd": true
    }],

ljharb commented 8 years ago

Thanks, I'll fix that. I'm confused how eslint is running into it though; it should not be linting inside node_modules.

jprianos-accusoft commented 8 years ago

It was a configuration issue on our gulp tasks, which has been fixed. I just figured I'd point it out to have the root issue corrected as well.

ljharb commented 8 years ago

This has been fixed in 8ffd263b37d629aa0773754ed3f756a03a17f387.

justmoon / node-extend

.eslintrc has invalid duplicate setting from npm #43