justmoon / relative-numbers

Relative line numbers package for Atom
https://atom.io/packages/relative-numbers
MIT License
37 stars 16 forks source link

HTMLElement.rootElement is deprecated in Atom 1.19.0-beta0 #39

Closed pingshunhuangalex closed 6 years ago

pingshunhuangalex commented 7 years ago

The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using rootElement and access the editor contents directly instead.

HTMLElement.rootElement (C:\Users\Pingshun Huang\AppData\Local\atom\app-1.19.0-beta0\resources\app\src\text-editor-element.js:23:10)
LineNumberView._updateSync (C:\Users\Pingshun Huang\.atom\packages\relative-numbers\lib\line-number-view.coffee:101:50)
_updateSync (C:\Users\Pingshun Huang\.atom\packages\relative-numbers\lib\line-number-view.coffee:3:59)
<unknown> (C:\Users\Pingshun Huang\.atom\packages\relative-numbers\lib\line-number-view.coffee:83:26)
ViewRegistry.performDocumentUpdate (<embedded>:20022:15)
<unknown> (<embedded>:19838:65)
avindra commented 7 years ago

Still an issue in beta 4

justmoon commented 6 years ago

Duplicate of #39 - fixed in 0.8.1.