justmoon / relative-numbers

Relative line numbers package for Atom
https://atom.io/packages/relative-numbers
MIT License
37 stars 16 forks source link

HTMLElement.rootElement is deprecated. - Stable #43

Closed heftyfunseeker closed 6 years ago

heftyfunseeker commented 7 years ago

The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using rootElement and access the editor contents directly instead.

HTMLElement.rootElement (C:\Users\Nicco\AppData\Local\atom\app-1.19.0-beta7\resources\app\src\text-editor-element.js:23:10)
LineNumberView._updateSync (C:\Users\Nicco\.atom\packages\relative-numbers\lib\line-number-view.coffee:101:50)
_updateSync (C:\Users\Nicco\.atom\packages\relative-numbers\lib\line-number-view.coffee:3:59)
<unknown> (C:\Users\Nicco\.atom\packages\relative-numbers\lib\line-number-view.coffee:83:26)
ViewRegistry.performDocumentUpdate (<embedded>:20098:15)
<unknown> (<embedded>:19914:65)
linjialiang commented 7 years ago

default

linjialiang commented 7 years ago

Is this plug-in still in maintenance

fenec commented 7 years ago

the fix was merged to master, but the release is yet to come. you can apply it on your own for now: https://github.com/justmoon/relative-numbers/pull/40/files

linjialiang commented 7 years ago

hy not release?

linjialiang commented 7 years ago

Thank you. The original question has been settled! But why isn't there a new version?

binarious commented 7 years ago

@justmoon A new version would help us 🙂.

shelldandy commented 7 years ago

@binarious @linjialiang while the author figures things out i've published the fix in a new package

https://atom.io/packages/relative-numbers-plus

atomicwrites commented 7 years ago

@mike3run It would be helpful if you explained what the difference was in the readme for your relative-numbers-plus package. I just installed relative-numbers and saw yours in the list but had no idea what the difference was.

shelldandy commented 7 years ago

@Aventura5 i dun goofed, lol what I did is grab the PR request the are talking about and published that, but it didn't work, i guess it has other breaking changes we are not aware of so for now you're better off applying this manually on the normal package installation:

https://github.com/justmoon/relative-numbers/pull/40/files

mauricerkelly commented 6 years ago

Hey @justmoon - could you please produce a new release for this? If you haven't got the bandwidth to do it, maybe you could ask for a volunteer to help maintain the package?

dannyfritz commented 6 years ago

http://flight-manual.atom.io/behind-atom/sections/maintaining-your-packages/#transferring-ownership

basicBrogrammer commented 6 years ago

Soooooo new version ?

shelldandy commented 6 years ago

lol its clearly not gonna happen (specially now on December...) you're better off either:

justmoon commented 6 years ago

Upgrade to 0.8.1. Apologies for the delay, I thought I had bumped the version but apparently not.