Closed falkoschindler closed 2 years ago
@falkoschindler this would be a good example where tests might help. I have the behavior if None values are part of the data to be sent to aggrid and therefore i keep avoing None values for the time being.
@WolfgangFahl I agree that tests would help. But as mentioned above, I didn't manage to reproduce the issue in a minimum example. The problem occurred in a larger user interface and I just noticed that line in aggrid.js. When handling the null
case, the problem was gone.
I have the behavior if None values are part of the data to be sent to aggrid and therefore i keep avoing None values for the time being.
Sorry, I don't get what you are saying.
~Since I don't seem to be able to commit to this repository directly, I created PR https://github.com/elimintz/justpy/pull/450 fixing this line.~ Nevermind, I managed to commit the change.
Under certain circumstances - which I can't manage to reproduce in a minimum example - I get a JavaScript error when updating an AG Grid:
I suspect it it caused by the condition
if (typeof def == "object")
in aggrid.js, which is true fornull
. ButObject.entries(def)
fails fordef == null
. So it should beif (typeof def == "object" && def !== null)
.A very similar line is in chartjp.js.