search

justpy-org / justpy

An object oriented high-level Python Web Framework that requires no frontend programming
https://justpy.io
Apache License 2.0
1.22k stars 95 forks source link

Outdated version of Quasar when served with NO_INTERNET #460

Closed rodja closed 1 year ago

rodja commented 2 years ago

JustPy still provides the outdated Quasar 1.9.14: https://github.com/elimintz/justpy/blob/72f94a9f1e7fcd2734b3c947ba2e830387083698/justpy/templates/local/quasar.js#L2.

The latest Quasar version is 2.7.7 which has many more features and bugfixes. I suggest we update the locally provided Quasar to the latest stable version.

rodja commented 2 years ago

@elimintz have you just copied the files as generated by https://quasar.dev/start/umd? Is that the right approach for an update?

WolfgangFahl commented 2 years ago

e.g.

wget https://cdn.jsdelivr.net/npm/quasar@2.7.7/dist/quasar.umd.prod.js
WolfgangFahl commented 2 years ago

How would i activate NO_INTERNET in a test? I have added quasar_example from the tutorial to examples/tutorial

elimintz commented 2 years ago

Quasar version 2 works only with Vue 3 and justpy uses Vue 2 so we have to use version 1 of Quasar. However, the good news is that when a feature is added to Quasar 2, it usually find its way to Quasar 1 also. I guess many projects that use Quasar are in the same situation as us.

So we should provide the latest Quasar 1 version which is 1.19.5

rodja commented 2 years ago

@elimintz What would it take to port JustPy to Vue 3? Are there any benefits or is it just very incompatible?

elimintz commented 2 years ago

The Vue components for me were the most difficult things to develop by far. I went through several design iterations. Justpy uses Vue in an original way, that as far as I can tell, no one used before.

This is the list of breaking changes between Vue 2 and Vue 3: https://v3-migration.vuejs.org/breaking-changes/

After reading it, I decided that I didn't have the appetite to take on the migration effort since for almost all users, they will not notice any difference. and it would be a very time consuming effort.

rodja commented 2 years ago

Ok. What do you think about the Vue 3 migration build? It looks like we may run Vue 2 code on Vue 3 with this...

elimintz commented 2 years ago

Not sure this is an option for us because we don't build the application, justpy templates download the cdn version.

WolfgangFahl commented 2 years ago

For milestone 0.7 it would be good to have the latest compatible version.

WolfgangFahl commented 1 year ago

see #685