justquick commented 2 years ago

Dynamic serializers and viewsets for the registered models in the actstream.registry
Default config for Action/Follow
Views to match (most) streams in the action manager
Ability to view your own actions
Custom serializer, viewset and permission options in settings
Related field evaluation using rest-framework-generic-relations

not ready for merge yet

502 #286

lgtm-com[bot] commented 2 years ago

This pull request introduces 7 alerts when merging 954181a26e12f883f421dda827874a549fe54917 into 34e428f9a171ba91b407995c820ed9348a2611d9 - view on LGTM.com

new alerts:

3 for Except block handles 'BaseException'
3 for Unused import
1 for Module is imported more than once

lgtm-com[bot] commented 2 years ago

This pull request introduces 9 alerts when merging ea5ad3947b8d2ef903409bfd2ca28c7f15c5ee89 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

4 for Except block handles 'BaseException'
4 for Unused import
1 for Module is imported more than once

lgtm-com[bot] commented 2 years ago

This pull request introduces 9 alerts when merging 704f1f37566e36f9e7ddff782e3a322bbc240960 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

4 for Except block handles 'BaseException'
4 for Unused import
1 for Module is imported more than once

lgtm-com[bot] commented 2 years ago

This pull request introduces 12 alerts when merging 8048985c600bc4ff9f32844251339dd044cf22a2 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

6 for Except block handles 'BaseException'
5 for Unused import
1 for Module is imported more than once

lgtm-com[bot] commented 2 years ago

This pull request introduces 12 alerts when merging 3fbf85fa3d9645d53a4f656039f688f072de31a1 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

6 for Except block handles 'BaseException'
6 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 12 alerts when merging 2a9327d36d34dee4ebaa78029f01cd7e9d125e88 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

6 for Except block handles 'BaseException'
6 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 13 alerts when merging df4b56904ccd540c71e38f3491e89dfd8b5caf93 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

7 for Unused import
6 for Except block handles 'BaseException'

lgtm-com[bot] commented 2 years ago

This pull request introduces 13 alerts when merging ff88265d60e8e147eaef3a1a8754198d8dd9993d into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

7 for Unused import
6 for Except block handles 'BaseException'

lgtm-com[bot] commented 2 years ago

This pull request introduces 13 alerts when merging c29787cf1dad72e82b49e0917ed1346561a8cce0 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

7 for Unused import
6 for Except block handles 'BaseException'

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging a572c336cd60fccdc04b9c76ff49ade87085ab10 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 20201ab9fa20c91919c382d54bf003ed4809ab1d into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 06e43fc22f3d97712aa5e162c40589ca1b90e600 into b0d3d82b724da9751e613ea38e1ce62d3bbae5d9 - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 4edf4a286a793c4708d4f6a105fe8b498d0a6f6e into 1d32e13c8152d54f2be151d01cc9451ce5f7fc7d - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging bb5c80b8e9de93b1021b2c030ebffcbff9cd88c2 into d83a954c5c40f22b6a026b50f8821c936195202e - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging dfa3eb4b169b6f294a2f333cbc746ac53640433f into 91154945502bcdd5f4941e4ba8c884112bbfd26d - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging e30d1cbe9dc2bb2d87200eb780fd4e7f384df587 into 91154945502bcdd5f4941e4ba8c884112bbfd26d - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 4eed6739a344ff8becdcb4c569ca03f86391140d into 91154945502bcdd5f4941e4ba8c884112bbfd26d - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

coveralls commented 2 years ago

Coverage: 94.972% (-0.3%) from 95.23% when pulling 1d7b225d7c204b8c15b881d939336e9c987cbed3 on drf into 890d13fd23d5c165a9f28841bd8df9b92f6ad662 on main.

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 25b6e8383ac0d7b0e2f9e10f8bf0b881b2c5d589 into c39808d0582f9cdd70e3fd4d31f3c68e99162c39 - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

auvipy commented 2 years ago

is there any work remain from your side?

justquick commented 2 years ago

i need to see how dependent this needs to be on drf_spectacular.... it's a great feature but should be optional. id like to publish the output schema api explorer it generates somewhere but it shouldnt b required when running tests or anything else. those parts also need some work but can probably wait

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 674126ae22d1d6bff714bbe925ecd458062290e0 into dd097fc2d525590d584ea4d751a3516f811dcc7b - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 4fa77548d3590e7bb23accac09731c41a376b3e2 into dd097fc2d525590d584ea4d751a3516f811dcc7b - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts when merging 93940ba86cb8ce7ebcd0f7d89fb187b33ffe64bb into dd097fc2d525590d584ea4d751a3516f811dcc7b - view on LGTM.com

new alerts:

5 for Except block handles 'BaseException'
5 for Unused import

justquick commented 2 years ago

im really tempted to merge this now but there are a couple things lacking. this really needs better tests and documentation. also we should push the openapi standard and provide a redoc site iamo. here's a run i did for the actstream drf api spec.

https://justquick.io/django-activity-stream/redoc.html?

auvipy commented 1 year ago

I checked the doc, what more you intended to complete?

justquick commented 1 year ago

we need to have a guide in the django-activity-stream documentation about how to use drf in actstream. just a page in the docs describing how to access it is enough. ill take a hack at something

i also want to strip the spectacular stuff out of the test app. just seems overkill and confusing. will add it in a later release

justquick commented 1 year ago

there are also changes to the ACTSTREAM_SETTINGS that add a DRF section which also needs documenting. hoping to finish this up soon

justquick commented 1 year ago

decided to rip off the bandaid and put this into main. please check it out and if there arent any issues then ill cut a 2.0 release

justquick / django-activity-stream

Django ReST Framework #503

502 #286