search

justquick / django-activity-stream

Generate generic activity streams from the actions on your site. Users can follow any actors' activities for personalized streams.
http://django-activity-stream.rtfd.io/en/latest/
BSD 3-Clause "New" or "Revised" License
2.36k stars 483 forks source link

Update docs to display support up to Python 3.12 and Django 5.0? #539

Closed wgordon17 closed 2 weeks ago

wgordon17 commented 5 months ago

Hey all (and @justquick), I've been doing some local work on django-activity-stream because I honestly didn't trust the doc's assertion that this is only supported up to Python 3.9 and Django 4.1 😅

I've managed to get tox and pytest passing for all environments now (a few minor tweaks to the tox.ini) with the exception of this specific text for Django 5.0. Commenting out that line allows for the rest of the tests to succeed with Django 5.0, and I've opened a thread in the Django Discord to see if there was an undocumented breaking change here that causes the translated text to no longer be stored in the database as LANGUAGE_CODE.

Once I get that sorted, do you have any concerns with me submitted a PR with the updated tox.ini changes, any changes I might need to do to resolve that specific test, and a docs update to reflect the changed support?

wgordon17 commented 5 months ago

Alrighty, problem identified, https://forum.djangoproject.com/t/new-5-0-behavior-storing-translated-string-in-database-solved/29483/5, and a PR is on it's way. Thankfully, this repo supports all the way up to 3.12 without any changes, but just needs a minor change to account for changes in Django 5.0 🎉

simkimsia commented 5 months ago

Just wanted to add that the docs don't seem to be updated as well. https://django-activity-stream.readthedocs.io/en/latest/changelog.html

Is this supporting Django 4.2?

wgordon17 commented 5 months ago

@simkimsia, I'm not the repo owner, but I did successfully run all the tests for this package on Django 4.2, all the way up through Python 3.12. There's a very minor change needed in order for the package to have the same support in Django 5+ that it has in the lower versions, the only implication of not having this fix is that translated strings get stored in the DB as translated, instead of the current functionality which is storing untranslated.

lociii commented 2 months ago

@justquick @auvipy would be great to see this merged soon as Django 5.x is already out for quite some time and this keeps people from upgrading. Thanks.