justreportit / thunderbird

Thunderbird plugin.
GNU General Public License v3.0
26 stars 3 forks source link

Failed account lookup causes unexpected behaviour #56

Open StephenAtty opened 8 months ago

StephenAtty commented 8 months ago

This is odd. 3.0.0 works fine on 115.4.1 (64-bit) Linux - I click on the button and a window pops up with the text and the spam message attached as a mesage. I click on send and it goes and the original message is left behind.

But when I upgrade to 3.1.0 I click on the button, no window pops up, the message vanishes (even if set to leave it) and nothing is sent.

I have 4 different identities set up (For 4 different accounts). I'm wondering if that is what is causing the problem as some of my email comes in using aliases (so email to x@xx.xx.com ends up in yy@xx.xx.com) so when you report it the tool is seeing x@xx.xx.com as the address but there isn't an identity that matches it

nicprov commented 8 months ago

@StephenAtty Your theory with the aliases definitely seems plausible because a lookup is done to find the correct account. I'll label this as a bug since, even if this isn't the issue you're facing, at a minimum, there should be validation that checks if no account is found and just return the first one in the list of something.