justsoft / video_thumbnail

This plugin generates thumbnail from video file or URL. It returns image in memory or writes into a file. It offers rich options to control the image format, resolution and quality. Supports iOS and Android.
MIT License
185 stars 273 forks source link

Migrate to flutter embedding v2 for Android #46

Closed wangbo4020 closed 3 years ago

wangbo4020 commented 4 years ago

Migrate to flutter embedding v2 for Android

wangbo4020 commented 4 years ago

45

justsoft commented 3 years ago

I would like to hold the v2 change, right now Flutter only complains the v1. Also your diffs seem have unnecessary changes.

thedude61636 commented 3 years ago

in the native android method call, you're using timeMs as an integer it should be changed to a long more than 32 bits of dart integer will automatically be translated to a long in java which will crash during casting to int

justsoft commented 3 years ago

in the native android method call, you're using timeMs as an integer it should be changed to a long more than 32 bits of dart integer will automatically be translated to a long in java which will crash during casting to int

Thanks, will do.

sgehrman commented 3 years ago

The plugin video_thumbnail uses a deprecated version of the Android embedding. To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs. If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.

wangbo4020 commented 3 years ago

temporary:


  video_thumbnail:
    git: 
      url: git@github.com:wangbo4020/video_thumbnail.git

And migrated to nullsafety.

The plugin video_thumbnail uses a deprecated version of the Android embedding. To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs. If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.

justsoft commented 3 years ago

Thank you guys!