justvanbloom / ga-bitbot

Automatically exported from code.google.com/p/ga-bitbot
GNU General Public License v3.0
0 stars 0 forks source link

bcbookie.py #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Have a buy order placed (book = held)
2. Have this order committed (old buy order oid, book = closed:commit)

What is the expected output? What do you see instead?
Expected result
record_synch: OID: 284fa068-1c29-4a98-bdfa-fd2be93df6fc  active
Seen:
!!!!!!! record_synch: orphaned or manual order found: TYPE: 1 AMOUNT: 0.1 
PRICE: 

Please provide any additional information below.
Perhaps the new sell order oid is not registered in self.records.
Old buy order oid (tagged as closed:commit) not removed from self.records, so 
it remains in book.html report

Original issue reported on code.google.com by alessand...@gmail.com on 1 Oct 2011 at 7:44

GoogleCodeExporter commented 9 years ago
When a position enters a closed:commit state the OID for the sell order is not 
captured. 

When this state is entered, the ability to monitor the status of the sell order 
along with stop loss and stop wait functionality are lost.

Need to add additional fields to capture the complete history for each position:
oid_sell,date_sell,localtime_sell. Prefixes should be added to the current buy 
side fields (oid,date,localtime). 

closed:commit should be renamed to open:sell
buy states should be renamed from open to open:buy or open:pending

closed states should be reserved for insuf funds, order not acknowledged, 
pending order timeout, stop loss, stop wait and verified sold orders.

The state machine will also need to be updated to handle the new/changed 
states. 

There is a concern with the MTGox API in that the behavior for partially sold 
orders is not known. Is the OID preserved for the remaining balance or is a new 
OID generated? This needs to be verified.

Original comment by brian.mo...@gmail.com on 2 Oct 2011 at 10:11

GoogleCodeExporter commented 9 years ago
bcbookie now tracks both buy and sell orders. 'tid's are now collected to 
assist with manual order reconciliation/auditing of the trade book with the 
downloadable account history available on the mt gox website.

Manual orders & sell orders are no longer automatically canceled.

Book report overhauled and is now linked into the web client. Each column of 
the report is now sortable. Functionality for searching/filtering is also 
included.

code is in the repo, will be included in the next release.

Original comment by brian.mo...@gmail.com on 8 Jan 2012 at 3:22