search

justwatchcom / sql_exporter

Flexible SQL Exporter for Prometheus.
MIT License
402 stars 109 forks source link

use automaxprocs? #137

Closed sebhoss closed 3 months ago

sebhoss commented 3 months ago

We are deploying sql_exporter into kubernetes and are currently setting GOMAXPROCS manually. If this package would use https://github.com/uber-go/automaxprocs we could remove that env var and simply set resource limits on the deployment.

dewey commented 3 months ago

Good point, would you be able to open a PR for that addition?

sebhoss commented 3 months ago

yep created https://github.com/justwatchcom/sql_exporter/pull/138

dewey commented 3 months ago

Perfect, thank you!