search

justwatchcom / sql_exporter

Flexible SQL Exporter for Prometheus.
MIT License
403 stars 109 forks source link

Feature: Provide support for RDS MySQL IAM Authentication #140

Closed ardens-jw closed 2 months ago

ardens-jw commented 2 months ago

I've modified this slightly to also support MySQL RDS IAM authentication (much the same as Postgres RDS IAM Authentication) - I've just combined the mysql:// and rds-mysql:// together and handled it there.

I've tested this on MySQL both with and without IAM authentication and appears to work fine!

ardens-jw commented 2 months ago

@dewey Let me know if you'd like any other changes made! 👍

ardens-jw commented 2 months ago

Apologies @dewey - I've removed the commented section.

dewey commented 2 months ago

All looks good, thanks for your contribution! I'm going to merge it and release a new version. 🙌

ardens-jw commented 2 months ago

Thank you. I'll wait for that release to be built as I'm using the built container release in some of my Ansible builds! 👍

dewey commented 2 months ago

https://github.com/justwatchcom/sql_exporter/releases/tag/v0.5.6 is out, the image is pushing right now and should be available in ~15 min.