justwatchcom / sql_exporter

Flexible SQL Exporter for Prometheus.
MIT License
401 stars 109 forks source link

Support for multiple configuration files #58

Open aivanov-citc opened 2 years ago

aivanov-citc commented 2 years ago

It would be nice to be able to add multiple configuration files. Then it will be possible to store these configs together with the configuration of the database from which the metrics are collected.

apiVersion: apps/v1
kind: Deployment
metadata:
  name: sql-exporter
spec:
...
  containers:
  - name: sql-exporter
    env:
    - name: CONFIG_FOLDER
      value: /config
...
    volumeMounts:
    - mountPath: /config
      name: config-volume
  volumes:
  - name: config-volume
    configMap:
      name: sql-exporter-config
 ...
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
...
configMapGenerator:
- name: sql-exporter-config
  files:
  - config1.yaml
  - config2.yaml
 ...
dewey commented 2 years ago

Hey, I think that's a good idea. I believe this is somehow covered by this issue: https://github.com/justwatchcom/sql_exporter/issues/44.

Is this something you'd be willing to work on?