search

justweihong / pe

0 stars 0 forks source link

Spelling of UndoneCommand vs UndoCommand #11

Open justweihong opened 3 years ago

justweihong commented 3 years ago

Not sure if its supposed to be UndoCommand or UndoneCommand. If they are two separate things, then what is the difference?

image.png

nus-se-bot commented 3 years ago

Team's Response

The Class diagram for NegateCommand is correct, it should be UndoneCommand and not UndoCommand.

The purpose of the UndoneCommand and UndoCommand is also clearly stated in the other sections of the DG:

image.png Purpose of UndoneCommand mentioned before the class diagram

image.png Purpose of UndoCommand under Undo section of DG

UndoneCommand handles marking assignments as not done (e.g if you accidentally marked an assignment as done and want to unmark the assignment as done), while UndoCommand handles undoing of commands (e.g if you deleted an assignment, using undo will restore the deleted assignment and add it back into your assignment list)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]