search

justweihong / pe

0 stars 0 forks source link

prioritize command is not invalid when priority level entered is the same #6

Open justweihong opened 3 years ago

justweihong commented 3 years ago

For done command, a task cannot be marked undone if it is alraeady undone. That's the same for done. And that is handled properly.

However, for task with low priority can still be set as low priority again.

image.png

nus-se-bot commented 3 years ago

Team's Response

We did not see the need to implement a restriction to prioritize an assignment again with the same priority as it does not cause any problems to the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Unfortunately, I do not completely agree that this issue is not in scope. If I happen to mistakenly undone a task that has already been undone, I get to receive an error message to reflect the task is already set as undone. In contrast, a task that already has a low priority can still be set as a low priority again without any error message. While this is does not affect the functonality of setting low priority, it shows the inconsistency in the error messages handling of the different features. As such, this should at least be a considered a bug, whether or not verylow or low.