search

juttle / juttle-viz

Juttle Visualization Library
Apache License 2.0
11 stars 4 forks source link

tests against node v5 #26

Closed rlgomes closed 8 years ago

rlgomes commented 8 years ago

@go-oleg @mnibecker we were missing the testing against v5

mattnibs commented 8 years ago

Being that this library only runs in the browser in production I somewhat question the utility of running tests in Node 5 for this

rlgomes commented 8 years ago

If we ran in atom as a plugin would it still be within the context of a browser ? (ie webkit engine ?) If it really doesn't make sense then I'll close this.

mattnibs commented 8 years ago

That's a good reason. I don't think it hurts, and it also is good to make sure our build processes work in 4+5. +1