search

juttle / juttle-viz

Juttle Visualization Library
Apache License 2.0
11 stars 4 forks source link

time-bars fix: when trimming data for drawing, save it back into this data #71

Closed go-oleg closed 8 years ago

go-oleg commented 8 years ago

In draw() we were filtering this.data based on the xScale to avoid drawing things that aren't going to be visible anyways. We were just storing the filtered version locally for the purpose of draw(). However, in getLeftTimeBoundForPoint(), which is accessed from draw(), we were access this.data. Because of this, there was a discrepancy in array length and index numbers of the points. This caused incorrect LeftTimeBound calculations.

@mnibecker

mattnibs commented 8 years ago

+1

demmer commented 8 years ago

+2