Closed go-oleg closed 8 years ago
+1
On Mon, Mar 21, 2016 at 1:51 PM, Oleg Seletsky notifications@github.com wrote:
We used to do this in timechart and barchart, but stopped because the majority of the time it didn't generate a title that made sense (juttle is also less time-series focused. Stop doing it in scatterchart as well.
This also fixes #84 https://github.com/juttle/juttle-viz/issues/84.
@davidvgalbraith https://github.com/davidvgalbraith @VladVega
https://github.com/VladVega
You can view, comment on, or merge this pull request online at:
https://github.com/juttle/juttle-viz/pull/85 Commit Summary
- scatterchart: don't default scatterchart title to name field
File Changes
- M src/views/scatterchart.js https://github.com/juttle/juttle-viz/pull/85/files#diff-0 (10)
Patch Links:
- https://github.com/juttle/juttle-viz/pull/85.patch
- https://github.com/juttle/juttle-viz/pull/85.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/juttle/juttle-viz/pull/85
Michael Demmer Jut - CTO / VP Engineering demmer@jut.io
We used to do this in timechart and barchart, but stopped because the majority of the time it didn't generate a title that made sense (juttle is also less time-series focused. Stop doing it in scatterchart as well.
This also fixes https://github.com/juttle/juttle-viz/issues/84.
@davidvgalbraith @VladVega