search

jutzig / github-release-plugin

uses the github release api to upload files
69 stars 24 forks source link

allows upload artifacts from project submodules. #11

Closed adelolmo closed 9 years ago

adelolmo commented 9 years ago

This small change allows maven submodules to upload their own artifacts.

An usage example can be found here: https://github.com/adelolmo/biblio

jutzig commented 9 years ago

Thank you for the pull request, but I don't really see the need for it. The plugin already works for submodules (and I use it that way). It is a known issue with maven that when using git you need to repeat the scm section per submodule. This change seems to be a workaround for that, but if you don't have the scm section defined per submodule many other things (like maven release plugin) won't work anyway.

adelolmo commented 9 years ago

Thanks for the tip. I'll use the scm workaround from now on.