jutzig / github-release-plugin

uses the github release api to upload files
69 stars 24 forks source link

Command line arguments for username and password not supported #12

Closed EvgeniGordeev closed 9 years ago

EvgeniGordeev commented 9 years ago

It's impossible to provide scm username and password in command line like

mvn github-release:release -Dusername=myUserName -Dpassword=myPassword

Plugin depends on the settings file what might be a tedious task to provide a separate one in CI environment.

jutzig commented 9 years ago

You can put properties instead of actual credentials in your settings.xml and then provide those properties as system properties. With other plugins like maven-wagon it's usually done the same way.

EvgeniGordeev commented 9 years ago

Yes, there might be workarounds like this. But you still don't want to hold in repository any environment specific files.

EvgeniGordeev commented 9 years ago

Compare with maven-release-plugin which allows:

release:perform --batch-mode -Dusername=${scm.username} -Dpassword=${scm.password}
EvgeniGordeev commented 9 years ago

Do you plan to make a new release with this issue?

jutzig commented 9 years ago

Yes, release 1.1.1 just passed staging and should be available on central