search

jutzig / github-release-plugin

uses the github release api to upload files
69 stars 24 forks source link

Fix #16: Added support for GitHub Enterprise instances #51

Closed anenviousguest closed 8 months ago

anenviousguest commented 8 months ago

This RP adds support for customizing the GitHub API endpoint. This is needed if we want to publish releases to GitHub Enterprise instances hosted inside organizations.

The endpoint is inferred based on the <scm> connection string and falls back to a regular public one (https://api.github.com).

It should resolve #16.

anenviousguest commented 8 months ago

@jutzig I tested the public part with my fork of this repo, and the enterprise part within our organization, both work well.

Thus far I published this version to our internal maven central mirror so that people in our org can start using it, but would appreciate a review and an official release as well.

Thank you.

jutzig commented 8 months ago

@anenviousguest thank you very much for the pull request, looks great :+1: I'm a little swamped right now, so I can't thoroughly review the changes today, but I think I'll find some time on the weekend to merge and create a new release. Thanks again!

jutzig commented 8 months ago

Thanks again for the change. I've merged it and uploaded release 1.5.1

anenviousguest commented 8 months ago

Thanks a lot @jutzig for a quick turnaround! Did you by any chance upload the plugin to Maven Central?

jutzig commented 8 months ago

Yes, I deployed it last night and version 1.5.1 should be available on central.

anenviousguest @.***> schrieb am So., 19. Nov. 2023, 21:55:

Thanks a lot @jutzig https://github.com/jutzig for a quick turnaround! Did you by any chance uploaded the plugin to Maven Central?

— Reply to this email directly, view it on GitHub https://github.com/jutzig/github-release-plugin/pull/51#issuecomment-1817974937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMOELACE5FCFP5ITCTVV7TYFJW4ZAVCNFSM6AAAAAA7J42JMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXHE3TIOJTG4 . You are receiving this because you were mentioned.Message ID: @.***>

anenviousguest commented 8 months ago

Ah, thanks. I see it was uploaded to oss.sonatype.org, not to mvnrepository.com Cool 👍🏻

jutzig commented 8 months ago

Yes, it gets mirrored from there. Depending on where you look, it can take a bit to be visible everywhere. The important one is central, and there it should already be available.