jutzig / github-release-plugin

uses the github release api to upload files
69 stars 24 forks source link

Fixes #52: added support for automatically generated release notes. #53

Closed anenviousguest closed 7 months ago

anenviousguest commented 8 months ago
Use-case Screenshot
Generated when the changes were made via pull requests image
Generated when the changes were made by directly committing into master image
anenviousguest commented 8 months ago

@jutzig would very much appreciate a review. Thank you.

anenviousguest commented 8 months ago

hi @jutzig , would be great to hear your feedback on this one.

jutzig commented 8 months ago

Hi @anenviousguest Thanks again for another pull request, that sounds like a great idea. TBH, I didn't even know that github does automatic release note generation like that. I assume following this, one can customize the default output? https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

What do you think about adding the first picture from your pull request as an example to the readme and include the link to automatic release notes description? I don't want to use the picture without permission, since it includes your user handle...

anenviousguest commented 8 months ago

Hi @jutzig

I assume following this, one can customize the default output? https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

I guess so, at least on the API page they do mention that YAML file.

What do you think about adding the first picture from your pull request as an example to the readme and include the link to automatic release notes description? I don't want to use the picture without permission, since it includes your user handle...

No prob at all, let me update the README then...

anenviousguest commented 8 months ago

Hi @jutzig , I updated the README with your link and put a screenshot there as well.

anenviousguest commented 8 months ago

Hi @jutzig , would appreciate a feedback on this one, thanks a lot.

jutzig commented 7 months ago

Thank you, looks great. I'll prepare a release now