search

jutzig / github-release-plugin

uses the github release api to upload files
69 stars 24 forks source link

this fixes issue#6 #7

Open emmanuelmathot opened 9 years ago

emmanuelmathot commented 9 years ago

It fixes #6 This is not the most elegant solution but at least it checks the hostname

Signed-off-by: Emmanuel Mathot emmanuel.mahot@gmail.com

jutzig commented 9 years ago

Thanks for the patch, but I don't want to merge it like that, because that would be a security issue... It seems that the certificate on uploads.github.com is valid for *.githubusercontent.com. Did you get that same certificate as well? IMO there's two possible reasons. Either it's an issue on github side, or they changed the upload URL in which case we should fix the github java API