application hangs with exception in issuestring.py

[GoogleCodeExporter]

What version of ComicTagger are you using?
ComicTagger v1.1.12-beta

On what operating system (Mac, Linux, Windows)? What version?
Linux (Linux Mint 15 Olivia, 3.8.0-35-generic)

GUI or command line?
GUI

What steps will reproduce the problem?
1. click "Search online" (for different type of comics - numbered or not 
numbered)

What is the expected output? What do you see instead?

Expected to find or not find the issue.
Application stops in modal state, nothing can be clicked.

Console prints out an exception:

  File "/home/nejc/workspace/oss/comictagger-read-only/comictaggerlib/taggerwindow.py", line 962, in queryOnline
    new_metadata = comicVine.fetchIssueData( selector.volume_id, selector.issue_number, self.settings )
  File "/home/nejc/workspace/oss/comictagger-read-only/comictaggerlib/comicvinetalker.py", line 360, in fetchIssueData
    if IssueString(issue_number).asString() is None:
  File "/home/nejc/workspace/oss/comictagger-read-only/comictaggerlib/issuestring.py", line 52, in __init__
    if text[0] == '-':

I have done some debugging and this happens if "text" variable is passed as an 
empty string or a int.

I have fixed it with attached patch for comictaggerlib/issuestring.py, but 
haven't investigated if this is the correct method - patch just prevents the 
exception - it should be investigated why int or empty string gets here.

Original issue reported on code.google.com by mr.n...@gmail.com on 6 Apr 2014 at 9:30

Attachments:

• ct.diff

[GoogleCodeExporter]

There should definitely be exception handling there, but I'd like to re-create 
the error before I fix it.  What are you searching for when this happens?  That 
is, what text is in the fields in the form?

Original comment by bevi...@gmail.com on 8 Apr 2014 at 2:49

[GoogleCodeExporter]

I must admit I don't remember, but I have removed my changes and are continuing 
tagging process - the exception was quite frequent so I'm sure I'll run into it 
again.

Original comment by mr.n...@gmail.com on 8 Apr 2014 at 4:57

[GoogleCodeExporter]

Thanks!  I've not had anyone mention this one before and haven't run into it 
myself.  I'm guessing there was a particular situation with respect to filename 
parsing.  Next you see it, pass along the original filename, and what it got 
parsed into on the entry form.

Original comment by bevi...@gmail.com on 8 Apr 2014 at 4:59

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

And here it is.

Filename "Avengers - Solo (2012) (TPB) (digital-Empire).cbz"

I add it via Open Folder

parsed fields are:
Series: "Avengers - Solo"
Year: "2012"

After clicking Search Online the correct comic is found (with manual 
intervention) but later exception is thrown.

Original comment by mr.n...@gmail.com on 8 Apr 2014 at 5:03

[GoogleCodeExporter]

This is very weird.  I made it happen once, by typing a space in the issue 
field, but then couldn't re-create it.  Ah, well.  I'll apply your patch, and 
it'll be in the next release. 

Thanks for the help!

Original comment by bevi...@gmail.com on 8 Apr 2014 at 5:39

• Changed state: Started

[GoogleCodeExporter]

added in 1.1.13

Original comment by bevi...@gmail.com on 9 Apr 2014 at 3:12

• Changed state: Fixed