juvenn / mustache.vim

Vim mode for mustache and handlebars (Deprecated)
github.com/mustache/vim-mode
125 stars 14 forks source link

Additional HTML container groups #10

Closed bruno- closed 11 years ago

bruno- commented 11 years ago

First of all, thanks for making this plugin. I use it for working with handlebars and it works nice!

About this pull request: I've noticed that handlebars (or mustache) variables {{ ... }} aren't highlighted properly when inside <a href....>{{ stuf }}</a> tag. To be precise - they are highlighted as text within a html link (special + underline highlight).

The same happens within <u> and <b> and <i> tags.

From looking at the plugin source I got the impression that mustache/handlebars variables should have the highest syntax highlight priority. (at least they seem to have more priority than html header tags)

Hopefully, this pull request enables proper highlighting for handle./mustac. variables within a, u, b and i tags.

Let me know what you think?

juvenn commented 11 years ago

Hi @bsutic , good to see your improvements, and thanks. As I have not been working with mustache or handlebars for a long time, I have few contributions thereof. If you're working on mustache a lot, I'd like to add you as a collaborator to this project, so you're going to have commit permission directly to this project.

Would you like to?

Again, very much thanks!

bruno- commented 11 years ago

Hi @juvenn , I'm glad that you found the improvement useful. Yes, please feel free to add me as a contributor.

In the mean-time, since I didn't know will you accept this pull-request, based on this project - I have made another one here. It has some improvements - matchit support for html most useful I think. I have tried to give credit to you and this project as well.

If you want, I would be happy to close that project and bring in the improvements to this one (this one is longer living and the original one in the end).

So yea, add me and I'll open a pull request here so we can discuss together what to bring in. Thanks!