search

juxt / bidi

Bidirectional URI routing
MIT License
991 stars 92 forks source link

Bidi brings older version of `ring-core` into projects; should it be :scope "provided"? #182

Open timothypratley opened 6 years ago

timothypratley commented 6 years ago

Including bidi as a dependency can break handlers that are expecting a higher version of ring-core: https://github.com/ptaoussanis/sente/issues/322

Should the ring-core dependency be :scope "provided" to avoid this?

SevereOverfl0w commented 6 years ago

For setting the scope to provided in leiningen, a profile is preferred (https://github.com/technomancy/leiningen/blob/master/doc/PROFILES.md#default-profiles mentions this briefly).

I agree ring-core should be in :provided scope, as it's not necessary in order to use bidi at all.