search

juxt / edge

A Clojure application foundation from JUXT
https://juxt.pro/edge/
MIT License
503 stars 62 forks source link

Update cljs_calva_settings.json #120

Open PEZ opened 4 years ago

PEZ commented 4 years ago

These changes are made:

  1. "cljsType": "none" added to backend only jack-in. The lack of this is today stopping jack-in in Calva.
  2. Custom commands added for starting the system and reloading the backend code. When the user invokes this in Calva (ctrl+alt .) he will get a prompt with the two commands. Given how this works in VS Code, reloading the Clojure code is now this key sequence: ctrl+alt+. 2 enter.
  3. Old backward compatibility custom cljs setting is now removed.
SevereOverfl0w commented 4 years ago

This seems like it's for the clojurescript settings, but is removing the clojurescript stuff.

  1. How do tell we calva about the location of the repl environment now?
  2. Should this JSON be only for clojure? Which we haven't yet setup, but definitely should.
PEZ commented 4 years ago

It is only removing the old, no-longer-used-by-calva cljs settings. The active settings are still there from line 19 in the new file:

https://github.com/juxt/edge/pull/120/commits/1043077dc944156fe54351af44aa3b94ed4f8360#diff-f6bafef1d75590e83c79211f86e5b30bL19

(You'll need to expand the view to show the referenced line.)

Not sure I follow about the other questions. But as it is now the user gets two launch options when jacking in to the created project:

  1. Backend only
  2. Backend + frontend

If choosing the latter both CLJ and CLJS REPLs will be set up and connected, by Calva Jack-in. It is the same as in this cheesy video: https://youtu.be/a2vRDYXDAug