juxt / pack.alpha

Package clojure projects
MIT License
259 stars 35 forks source link

Handle non-existent :path #110

Open SevereOverfl0w opened 2 years ago

SevereOverfl0w commented 2 years ago

See https://github.com/juxt/pack.alpha/discussions/109

https://github.com/juxt/pack.alpha/blob/47ee078edcd6f85353dc5455dc0232c64a46e2ef/src/juxt/pack/jib.clj#L114 is the likely culprit.

The question is, what should be done? Presumably the Clojure CLI ignores this, and we should do the same.

We may want to move the exists check into :builder to match the exact behaviour of the CLI (I'm making assumptions here about what the CLI ends up doing!)

:builder (if (Files/exists ...) (.addEntryRecursive builder ...) builder)