search

juxt / yada

A powerful Clojure web library, full HTTP, full async - see https://juxt.pro/yada/index.html
MIT License
735 stars 98 forks source link

I291: Corrected multipart file boundary parsing. #303

Closed leguma closed 5 years ago

leguma commented 5 years ago

As more files are added to multipart requests, the chance of file parts coming in an order that triggers the issue discussed in #291 increases. Perfect reproduction remains difficult due to the stochastic nature of this issue, but the test cases outlined in the issue should provide enough information to replicate the issue to some degree.

All credit goes to @p-himik for finding this solution.

malcolmsparks commented 5 years ago

Released in 1.2.15.1. Cherry picked onto master.

malcolmsparks commented 5 years ago

Thanks @leguma and of course @p-himik

leguma commented 5 years ago

Awesome, thanks @malcolmsparks! Deleting the custom multipart.clj from our projects now in favor of using the fixed release. One less bit of technical debt to worry about. :)

p-himik commented 5 years ago

@malcolmsparks Awesome, thanks! One small issue - you said you cherry picked it onto master, but it's not there.

malcolmsparks commented 5 years ago

It's my local master, will push in due course.