search

juxt / yada

A powerful Clojure web library, full HTTP, full async - see https://juxt.pro/yada/index.html
MIT License
735 stars 97 forks source link

Cannot use aleph 0.5.0 with yada #328

Open ieugen opened 2 years ago

ieugen commented 2 years ago

The underlying issue is https://github.com/clj-commons/aleph/issues/605 .

We tried to upgrade our project and it failed.

ivarref commented 2 years ago

Did you solve this issue?

My deps.edn looks like this:

  yada/yada                         {:mvn/version "1.2.16" :exclusions [byte-streams/byte-streams aleph/aleph]}
  aleph/aleph                       {:mvn/version "0.5.0"}

Works here.

Edit: formatting.

ivarref commented 2 years ago

Sorry, that did indeed not work. It worked with aleph 0.4.7 though.

iku000888 commented 1 year ago

The underlying issue is in fact resolved so it would save hours of googling for future yada newbies trying to run yada on top of latest version of aleph!

KingMob commented 1 year ago

It also appears that placing Aleph/byte-streams higher in the dependency tree prevents issues, if you're trying to use newer Aleph versions.

boxxxie commented 1 year ago

@KingMob could you provide a code example so it's easy for others to quickly implement this workaround

KingMob commented 1 year ago

@boxxxie Sure, the key point is just to place byte-streams and/or aleph earlier in the dependencies than yada, so their versions supersede yada's older versions (yada hasn't been updated in 4 years).

It should be something like:

Lein:

:dependencies [[...
               [org.clj-commons/byte-streams "0.3.3"]
               [aleph "0.6.3"]
               [yada "1.2.15.1"]
               ...]

tools.deps:

{:deps {...
        org.clj-commons/byte-streams {:mvn/version "0.3.3"}
        aleph/aleph {:mvn/version "0.6.3"}
        yada/yada {:mvn/version "1.2.15.1"}
        ...}}