search

juxtopposed / realtimecolors

Real-time UI Colorpicking Tool. See your favorite colors of choice for a website in real time.
https://realtimecolors.com
Other
833 stars 30 forks source link

[Bug]: Font URL are unencoded #97

Closed Ben-Brady closed 10 months ago

Ben-Brady commented 11 months ago

Is there an existing issue for this?

Describe the bug

The font imports in the exported css do not encode whitespace, this messes with some CSS minifiers and tools because whitespace in URLs is possible non-standard (I'm not really sure, but MDN recommends against it, https://developer.mozilla.org/en-US/docs/Web/CSS/url#string).

Reproduction Steps

  1. Go to 'https://www.realtimecolors.com/?fonts=Noto%20Serif%20Georgian-Noto%20Serif%20Georgian'
  2. Click on 'export'
  3. Look at the css font @import
  4. See error

Expected behavior

URL spaces would be encoded as %20

Screenshots

No response

Device Info

OS Windows 10 Browser; Firefox Version: 120

Additional context

No response

juxtopposed commented 11 months ago

This should be resolved now (in v3.5)