juxtopposed / stacksorted

Find Inspiration in Design Elements.
https://stacksorted.com
264 stars 39 forks source link

Fix modal overflow issue in Stack Sorted #34

Closed mh-jsx closed 1 year ago

mh-jsx commented 1 year ago

Problem

The modal in Stack Sorted currently has a fixed height, which causes images to overflow when their dimensions exceed the modal's dimensions. This results in a poor user experience and hides action buttons.

Proposed Solution

To address this issue, we should set the CSS property of images within the modal to "overflow: auto" so that they do not overflow from their parent container.

Steps to Reproduce

  1. Open a website. stacksorted
  2. Click on any of the card with large image e.g: Border effects Vercel
  3. Observe the image overflowing from the modal.

Expected Behavior

Images within the modal should not overflow from the modal's image area.

Additional Information

juxtopposed commented 1 year ago

Closing as completed in #35