PA Review: User Authentication - Githubissues

juzen2003 / EasyNote

A place to keep track of your ideas

https://easynote.herokuapp.com/

0 stars 0 forks source link

PA Review: User Authentication #2

Open juzen2003 opened 6 years ago

juzen2003 commented 6 years ago

[x] Backend: DB, model, controller, views
[x] Redux Loop: ajax, actions, reducer
[x] Presentational Components and Containers
[x] Styling
[x] Smooth, bug-free navigation ('/' , '/login', 'singup')
[x] Adequate and appropriate seeds (Demo Login)

niartenyaw commented 6 years ago

Great job! See some comments below. Make sure you are styling on a mac screen, not a monitor. The monitor screen size is huge and can mess things up!

Functionality

[x] The errors displayed to the user should be relevant, not just invalid credentials. Is the password too short? Username taken? They'll need to know that
[x] Going to https://easynote.herokuapp.com/#/voeiurviuerbv should redirect to a relevant page or show me an error page

Styling

[x] The picture is cut off by the right side of the screen. It should also be touching the top border like Evernote
[x] The top header is a little off. Too tall and the logo/button isn't far enough apart.
[x] Sign up form should be a bit wider and have the logo above it
[x] Adding errors to the page shouldn't move the form up or down

niartenyaw commented 6 years ago

Sweet! A one more small thing and then you can close!

Styling

[x] I shouldn't be able to scroll on any of the session form pages (/ too)