Open huan opened 4 years ago
I think we should use Image
class to get artwork
firstly, and then forward this one.
Class Image
will work for these two methods:
forward()
toFileBox()
Now it seem that it could work for toFileBox()
only?
The message.forward()
is using the puppet.messageForward()
to forward a message by massageId
, which is implemented by the Puppet:
And in our Puppet, the messageForward()
will call this.messageFile(messageId)
, which is an abstract method implemented in our PuppetDonut
.
So we need to look at the messageFile()
in PuppetDonut and make sure it will return the HD image to fix this issue.
Related commit: https://github.com/juzibot/wechaty-puppet-donut/commit/2b1baa11846e3b1b47f363222bd2f77008e099fe
After upgrade donut for Friday Bot
and Oss Chat
, let's keep watching on this issue for one week.
It's great to know that you have fixed this problem!
The best practice of fixing bugs is to link to the related issue with the source code commit message because it will help other developers getting to know which bug has been fixed. Please always refer to the issue number in the commit message (if there's any), thanks!
Reproduce steps:
user
forward an image message to thebot
bot
get an imagemessage
instance from theon(message, ...)
eventmessage.forward(room)
, which the room is a Room instance.Expected
The full-size image should be forwarded.