Open su-chang opened 2 years ago
We need a new event for receive these notifications:
Due to we have friendship event already, I think it's better to reuse this event receive friendship delete event.
friendship
friendship delete
The only one thing we should do is that add a new type in FriendshipType: https://github.com/juzibot/wechaty-puppet/blob/5fb409bb05bf8d011fc2935982025e807286d907/src/schemas/friendship.ts#L1-L6
FriendshipType
Named the new FriendshipType type as Delete.
Delete
export enum FriendshipType { Unknown = 0, Confirm, Receive, Verify, Delete, }
These two notifications should use the same type Deleted? Or add different type for them, e.g. Remove and Delete.
Deleted
Remove
Vote for add two different FriendshipType: Remove and Delete
It would be better to clearly separate the two concept with the types, so either Removed and Delete or Deleted and Delete.
Removed
Background
We need a new event for receive these notifications:
Due to we have
friendship
event already, I think it's better to reuse this event receivefriendship delete
event.The only one thing we should do is that add a new type in
FriendshipType
: https://github.com/juzibot/wechaty-puppet/blob/5fb409bb05bf8d011fc2935982025e807286d907/src/schemas/friendship.ts#L1-L6Named the new
FriendshipType
type asDelete
.Discuss
These two notifications should use the same type
Deleted
? Or add different type for them, e.g.Remove
andDelete
.