search

juzzlin / Heimer

Heimer is a simple cross-platform mind map, diagram, and note-taking tool written in Qt.
GNU General Public License v3.0
887 stars 112 forks source link

constants.hpp: compiler error "Alias template 'QVector' requires template arguments" fix #220

Closed DzianCPP closed 1 year ago

DzianCPP commented 1 year ago

Hi! First of all, thank you for this beautiful and simple-to-use application. Also, thank you for sharing the source code and giving guys like me, new to development, a cool opportunity to get a glance at a real product code. And to have a chance to contribute, of course :-)

My IDE (Qt Creator) wouldn't compile build the project, because clang wanted to specify QVector type. I hope, this fix can be meaningful.

juzzlin commented 1 year ago

I cherry-picked your 705889f, thanks!

If you are new to Git, you might want to learn interactive rebase with git rebase -i COMMIT_HASH that allows you to clean up your local history (glue commits together, change commit order, drop commits etc etc).

Also, Git Gui is a nice tool to with which you can easily split changes within a file into multiple commits by selecting certain changes with a mouse.

DzianCPP commented 1 year ago

Oh, thanks for a hint:)